Skip to content

Conversation

rutvik-monpara
Copy link

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Ui Form Reset button not working as expected #40092

Manual testing scenarios (*)

  1. Open a Customer Add/Edit Form in Admin
  2. Click on Reset button
  3. Without reloading, the form data will get reset

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Jul 23, 2025

Hi @rutvik-monpara. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@rutvik-monpara
Copy link
Author

@magento run all tests

@rutvik-monpara
Copy link
Author

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento run all tests

Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rutvik-monpara,

Thanks for the contribution!

It seems some functional tests are failing due to this change, request you to fix them also fix the failed static test.

Thanks

@engcom-Hotel engcom-Hotel moved this from Pending Review to Changes Requested in Community Dashboard Sep 16, 2025
@rutvik-monpara
Copy link
Author

Hello @engcom-Hotel,
I don’t understand why the automatic tests are failing. Could you please review the code? There are only two files with a single-line change each, and one of those files is just a test file. So effectively, there’s only one main file with changes, and even there I haven’t made any major modifications, just updated an ID that someone had changed earlier, which actually shouldn’t have been altered. That’s what was causing the issue. Kindly review the code once.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: needs update Progress: pending review Project: Community Picked PRs upvoted by the community
Projects
Status: Changes Requested
Development

Successfully merging this pull request may close these issues.

Ui Form Reset button not working as expected
4 participants